JPG not valid extension for media box image

[rscottfree]

I uploaded some pictures in the rotate directory to be displayed in the media box. I exported the images from picasa (windows) which exports as a jpg, but the actual file extension is JPG (not the uppercase). Anyway, I put them where they are supposed to be but nothing showed up. I was like, what the!

But then I renamed them to jpg and the images showed just fine. The PHP code must be searching for images only with a lowercase extension of jpg, and not JPG. Seems like an easy fix.

Also, I can rename the image to image.jpg.JPG and it works fine as well. Must be a regex search like (.*\.jpg) with no end parameter restrictions.

This may more appropriately be put in the feature request section, but I figure people will come here if they have the same problem.

[kingdomgeek]

Regarding the image rotator itself (not necessarily the Thesis options page), the relevant line is this:

PHP Code:

        if (strpos($file, '.jpg') || strpos($file, '.jpeg') || strpos($file, '.png') || strpos($file, '.gif'))  { 


in the file /lib/functions/multimedia_box_functions.php.

More file types can be accounted for by adding "|| strpos($file, '.JPG')" prior to the last ")"

And you're right, the code doesn't check that the extension is the last part of the filename. It merely checks that the extensions are present somewhere in the filename.

[rscottfree]

Nice. Thanks.

That line was getting a little long, so I used eregi, which uses regular expressions and cuts down on clutter as well as ignoring case. (And I'm guessing has a performance benefit.)

PHP Code:

if (eregi('(jpg|jpeg|png|gif)', $file)) { 


After all, such a clean theme deserves clean code too